diff options
| author | Dave Jiang <dave.jiang@intel.com> | 2020-06-26 11:12:56 -0700 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2020-07-13 14:48:02 +0530 |
| commit | 4548a6ad3d50c398aa12fa3ad45dd0611328f13b (patch) | |
| tree | c3cc9d9f57620eb52ba2cf9f5b0a9618b46ba457 /drivers/dma/idxd/irq.c | |
| parent | 0d5c10b4c84d6ae6255129e5f16a0d2119c74334 (diff) | |
| download | linux-4548a6ad3d50c398aa12fa3ad45dd0611328f13b.tar.bz2 | |
dmaengine: idxd: move idxd interrupt handling to mask instead of ignore
Switch driver to use MSIX mask and unmask instead of the ignore bit.
When ignore bit is cleared, we must issue an MMIO read to ensure writes
have all arrived and check and process any additional completions. The
ignore bit does not queue up any pending MSIX interrupts. The mask bit
however does. Use API call from interrupt subsystem to mask MSIX
interrupt since the hardware does not have convenient mask bit register.
Suggested-by: Ashok Raj <ashok.raj@intel.com>
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Link: https://lore.kernel.org/r/159319517621.70410.11816465052708900506.stgit@djiang5-desk3.ch.intel.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Diffstat (limited to 'drivers/dma/idxd/irq.c')
| -rw-r--r-- | drivers/dma/idxd/irq.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/dma/idxd/irq.c b/drivers/dma/idxd/irq.c index 6052765ca3c8..f3c1d9ae8b56 100644 --- a/drivers/dma/idxd/irq.c +++ b/drivers/dma/idxd/irq.c @@ -260,8 +260,6 @@ irqreturn_t idxd_wq_thread(int irq, void *data) processed = idxd_desc_process(irq_entry); idxd_unmask_msix_vector(irq_entry->idxd, irq_entry->id); - /* catch anything unprocessed after unmasking */ - processed += idxd_desc_process(irq_entry); if (processed == 0) return IRQ_NONE; |