diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-06-20 19:18:15 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-06-22 16:10:23 -0700 |
| commit | 8b3d743fc9e2542822826890b482afabf0e7522a (patch) | |
| tree | 649f7c39377d875d4150c7f126e7fd201158d2e1 /drivers/clk/clk-devres.c | |
| parent | 68bde8b2e3112d2f1ac52cbf078905f902950146 (diff) | |
| download | linux-8b3d743fc9e2542822826890b482afabf0e7522a.tar.bz2 | |
clk: Fix pointer casting to prevent oops in devm_clk_release()
The release function is called with a pointer to the memory returned by
devres_alloc(). I was confused about that by the code before the
generalization that used a struct clk **ptr.
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Fixes: abae8e57e49a ("clk: generalize devm_clk_get() a bit")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20220620171815.114212-1-u.kleine-koenig@pengutronix.de
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Tested-by: Linux Kernel Functional Testing <lkft@linaro.org>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Diffstat (limited to 'drivers/clk/clk-devres.c')
| -rw-r--r-- | drivers/clk/clk-devres.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c index 43ccd20e0298..4fb4fd4b06bd 100644 --- a/drivers/clk/clk-devres.c +++ b/drivers/clk/clk-devres.c @@ -11,7 +11,7 @@ struct devm_clk_state { static void devm_clk_release(struct device *dev, void *res) { - struct devm_clk_state *state = *(struct devm_clk_state **)res; + struct devm_clk_state *state = res; if (state->exit) state->exit(state->clk); |