diff options
| author | Guoqing Jiang <guoqing.jiang@cloud.ionos.com> | 2020-11-26 11:47:22 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2020-12-04 09:41:10 -0700 |
| commit | d3a95ccaaf4df94743a958c90ab85f4703e3a687 (patch) | |
| tree | 27546f078a969af51fa659df840c95acad9c5485 /drivers/block/rnbd/rnbd-clt-sysfs.c | |
| parent | 765c5c56ffde0a555ce69559ab275395fb1a12a9 (diff) | |
| download | linux-d3a95ccaaf4df94743a958c90ab85f4703e3a687.tar.bz2 | |
block/rnbd: call kobject_put in the failure path
Per the comment of kobject_init_and_add, we need to cleanup the memory
by call kobject_put.
Also we need to call kobject_del for the other failure cases if the
kobject_init_and_add doesn't fail.
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
Signed-off-by: Jack Wang <jinpu.wang@cloud.ionos.com>
Reviewed-by: Md Haris Iqbal <haris.iqbal@cloud.ionos.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/block/rnbd/rnbd-clt-sysfs.c')
| -rw-r--r-- | drivers/block/rnbd/rnbd-clt-sysfs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/block/rnbd/rnbd-clt-sysfs.c b/drivers/block/rnbd/rnbd-clt-sysfs.c index 5d3c3c80dab4..e3c3270b0cee 100644 --- a/drivers/block/rnbd/rnbd-clt-sysfs.c +++ b/drivers/block/rnbd/rnbd-clt-sysfs.c @@ -450,9 +450,11 @@ static int rnbd_clt_add_dev_kobj(struct rnbd_clt_dev *dev) ret = kobject_init_and_add(&dev->kobj, &rnbd_dev_ktype, gd_kobj, "%s", "rnbd"); - if (ret) + if (ret) { rnbd_clt_err(dev, "Failed to create device sysfs dir, err: %d\n", ret); + kobject_put(&dev->kobj); + } return ret; } |