summaryrefslogtreecommitdiffstats
path: root/drivers/atm/iphase.h
diff options
context:
space:
mode:
authorJiri Slaby <jslaby@suse.cz>2010-10-10 23:26:57 +0000
committerDavid S. Miller <davem@davemloft.net>2010-10-11 11:05:42 -0700
commitec622ab072e95cf96e78ab4d39d4eea874518c80 (patch)
tree8bd6a7a06f8f5c4f830d01b567532ec204d5feae /drivers/atm/iphase.h
parent5518b29f225dbdf47ded02cf229ff8225a2cdf82 (diff)
downloadlinux-ec622ab072e95cf96e78ab4d39d4eea874518c80.tar.bz2
ATM: iphase, remove sleep-inside-atomic
Stanse found that ia_init_one locks a spinlock and inside of that it calls ia_start which calls: * request_irq * tx_init which does kmalloc(GFP_KERNEL) Both of them can thus sleep and result in a deadlock. I don't see a reason to have a per-device spinlock there which is used only there and inited right before the lock location. So remove it completely. Signed-off-by: Jiri Slaby <jslaby@suse.cz> Cc: Chas Williams <chas@cmf.nrl.navy.mil> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/atm/iphase.h')
-rw-r--r--drivers/atm/iphase.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/atm/iphase.h b/drivers/atm/iphase.h
index b2cd20f549cb..077735e0e04b 100644
--- a/drivers/atm/iphase.h
+++ b/drivers/atm/iphase.h
@@ -1022,7 +1022,7 @@ typedef struct iadev_t {
struct dle_q rx_dle_q;
struct free_desc_q *rx_free_desc_qhead;
struct sk_buff_head rx_dma_q;
- spinlock_t rx_lock, misc_lock;
+ spinlock_t rx_lock;
struct atm_vcc **rx_open; /* list of all open VCs */
u16 num_rx_desc, rx_buf_sz, rxing;
u32 rx_pkt_ram, rx_tmp_cnt;