diff options
author | Lee Jones <lee.jones@linaro.org> | 2021-02-01 14:39:39 +0000 |
---|---|---|
committer | Jens Axboe <axboe@kernel.dk> | 2021-03-12 07:28:31 -0700 |
commit | 92a5e8827c9e1a851d8c7967e70fe247d4427f7d (patch) | |
tree | f92e9002c633bcc6feeb56e263db7d2ab9b19663 /drivers/ata/pata_optidma.c | |
parent | efd2cbe82f503e6fa3509987c7d46f39c7bd37a1 (diff) | |
download | linux-92a5e8827c9e1a851d8c7967e70fe247d4427f7d.tar.bz2 |
ata: pata_optidma: Fix a function misnaming, a formatting issue and a missing description
Fixes the following W=1 kernel build warning(s):
drivers/ata/pata_optidma.c:298: warning: expecting prototype for optidma_make_bits(). Prototype was for optidma_make_bits43() instead
drivers/ata/pata_optidma.c:319: warning: Function parameter or member 'r_failed' not described in 'optidma_set_mode'
drivers/ata/pata_optidma.c:361: warning: Function parameter or member 'pdev' not described in 'optiplus_with_udma'
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-ide@vger.kernel.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Diffstat (limited to 'drivers/ata/pata_optidma.c')
-rw-r--r-- | drivers/ata/pata_optidma.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/ata/pata_optidma.c b/drivers/ata/pata_optidma.c index fbcf0af34924..f6278d9de348 100644 --- a/drivers/ata/pata_optidma.c +++ b/drivers/ata/pata_optidma.c @@ -287,7 +287,7 @@ static void optiplus_set_dma_mode(struct ata_port *ap, struct ata_device *adev) } /** - * optidma_make_bits - PCI setup helper + * optidma_make_bits43 - PCI setup helper * @adev: ATA device * * Turn the ATA device setup into PCI configuration bits @@ -309,6 +309,7 @@ static u8 optidma_make_bits43(struct ata_device *adev) /** * optidma_set_mode - mode setup * @link: link to set up + * @r_failed: out parameter for failed device * * Use the standard setup to tune the chipset and then finalise the * configuration by writing the nibble of extra bits of data into @@ -354,7 +355,7 @@ static struct ata_port_operations optiplus_port_ops = { /** * optiplus_with_udma - Look for UDMA capable setup - * @pdev; ATA controller + * @pdev: ATA controller */ static int optiplus_with_udma(struct pci_dev *pdev) |