diff options
author | Parvi Kaustubhi <pkaustub@cisco.com> | 2019-02-09 09:28:30 -0800 |
---|---|---|
committer | Jason Gunthorpe <jgg@mellanox.com> | 2019-02-19 20:52:19 -0700 |
commit | 5bb3c1e9d4bc93a9eb4e44a52582d6aa72643b1e (patch) | |
tree | d2752199cb84ced4f13a903b912fdf2a917a7ba6 /certs | |
parent | ca22354b140853b8155692d5b2bc0110aa54e937 (diff) | |
download | linux-5bb3c1e9d4bc93a9eb4e44a52582d6aa72643b1e.tar.bz2 |
IB/usnic: Fix deadlock
There is a dead lock in usnic ib_register and netdev_notify path.
usnic_ib_discover_pf()
| mutex_lock(&usnic_ib_ibdev_list_lock);
| usnic_ib_device_add();
| ib_register_device()
| usnic_ib_query_port()
| mutex_lock(&us_ibdev->usdev_lock);
| ib_get_eth_speed()
| rtnl_lock()
order of lock: &usnic_ib_ibdev_list_lock -> usdev_lock -> rtnl_lock
rtnl_lock()
| usnic_ib_netdevice_event()
| mutex_lock(&usnic_ib_ibdev_list_lock);
order of lock: rtnl_lock -> &usnic_ib_ibdev_list_lock
Solution is to use the core's lock-free ib_device_get_by_netdev() scheme
to lookup ib_dev while handling netdev & inet events.
Signed-off-by: Parvi Kaustubhi <pkaustub@cisco.com>
Reviewed-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
Reviewed-by: Tanmay Inamdar <tinamdar@cisco.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Diffstat (limited to 'certs')
0 files changed, 0 insertions, 0 deletions