diff options
author | Stevens, Nick <Nick.Stevens@digi.com> | 2015-07-01 16:07:41 +0000 |
---|---|---|
committer | Guenter Roeck <linux@roeck-us.net> | 2015-07-01 13:56:27 -0700 |
commit | 347d7e45bd09ce09cbc30d5cea9de377eb22f55c (patch) | |
tree | 2372f376a79f0b97722a687de31a93af33ca3937 /block/bsg.c | |
parent | 56172d81a9bc37a69b95dd627b8d48135c9c7b31 (diff) | |
download | linux-347d7e45bd09ce09cbc30d5cea9de377eb22f55c.tar.bz2 |
hwmon: (mcp3021) Fix broken output scaling
The mcp3021 scaling code is dividing the VDD (full-scale) value in
millivolts by the A2D resolution to obtain the scaling factor. When VDD
is 3300mV (the standard value) and the resolution is 12-bit (4096
divisions), the result is a scale factor of 3300/4096, which is always
one. Effectively, the raw A2D reading is always being returned because
no scaling is applied.
This patch fixes the issue and simplifies the register-to-volts
calculation, removing the unneeded "output_scale" struct member.
Signed-off-by: Nick Stevens <Nick.Stevens@digi.com>
Cc: stable@vger.kernel.org # v3.10+
[Guenter Roeck: Dropped unnecessary value check]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Diffstat (limited to 'block/bsg.c')
0 files changed, 0 insertions, 0 deletions