diff options
| author | Mark Rutland <mark.rutland@arm.com> | 2019-09-25 16:49:46 -0700 | 
|---|---|---|
| committer | Linus Torvalds <torvalds@linux-foundation.org> | 2019-09-26 10:10:44 -0700 | 
| commit | b4ed71f557e458257e0f71b11969954acb389240 (patch) | |
| tree | 37be2ba912b15dcb0104badeea1eba798bec2fed /arch | |
| parent | cc22c800e15b03c87f0e97400f75eba998e75c6a (diff) | |
| download | linux-b4ed71f557e458257e0f71b11969954acb389240.tar.bz2 | |
mm: treewide: clarify pgtable_page_{ctor,dtor}() naming
The naming of pgtable_page_{ctor,dtor}() seems to have confused a few
people, and until recently arm64 used these erroneously/pointlessly for
other levels of page table.
To make it incredibly clear that these only apply to the PTE level, and to
align with the naming of pgtable_pmd_page_{ctor,dtor}(), let's rename them
to pgtable_pte_page_{ctor,dtor}().
These changes were generated with the following shell script:
----
git grep -lw 'pgtable_page_.tor' | while read FILE; do
    sed -i '{s/pgtable_page_ctor/pgtable_pte_page_ctor/}' $FILE;
    sed -i '{s/pgtable_page_dtor/pgtable_pte_page_dtor/}' $FILE;
done
----
... with the documentation re-flowed to remain under 80 columns, and
whitespace fixed up in macros to keep backslashes aligned.
There should be no functional change as a result of this patch.
Link: http://lkml.kernel.org/r/20190722141133.3116-1-mark.rutland@arm.com
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>
Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>	[m68k]
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/arc/include/asm/pgalloc.h | 4 | ||||
| -rw-r--r-- | arch/arm/include/asm/tlb.h | 2 | ||||
| -rw-r--r-- | arch/arm/mm/mmu.c | 2 | ||||
| -rw-r--r-- | arch/arm64/include/asm/tlb.h | 2 | ||||
| -rw-r--r-- | arch/arm64/mm/mmu.c | 2 | ||||
| -rw-r--r-- | arch/csky/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/hexagon/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/m68k/include/asm/mcf_pgalloc.h | 6 | ||||
| -rw-r--r-- | arch/m68k/include/asm/motorola_pgalloc.h | 6 | ||||
| -rw-r--r-- | arch/m68k/include/asm/sun3_pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/mips/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/nios2/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/openrisc/include/asm/pgalloc.h | 6 | ||||
| -rw-r--r-- | arch/powerpc/mm/pgtable-frag.c | 6 | ||||
| -rw-r--r-- | arch/riscv/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/s390/mm/pgalloc.c | 6 | ||||
| -rw-r--r-- | arch/sh/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/sparc/mm/init_64.c | 4 | ||||
| -rw-r--r-- | arch/sparc/mm/srmmu.c | 4 | ||||
| -rw-r--r-- | arch/um/include/asm/pgalloc.h | 2 | ||||
| -rw-r--r-- | arch/unicore32/include/asm/tlb.h | 2 | ||||
| -rw-r--r-- | arch/x86/mm/pgtable.c | 2 | ||||
| -rw-r--r-- | arch/xtensa/include/asm/pgalloc.h | 4 | 
23 files changed, 37 insertions, 37 deletions
| diff --git a/arch/arc/include/asm/pgalloc.h b/arch/arc/include/asm/pgalloc.h index 4751f2251cd9..b747f2ec2928 100644 --- a/arch/arc/include/asm/pgalloc.h +++ b/arch/arc/include/asm/pgalloc.h @@ -108,7 +108,7 @@ pte_alloc_one(struct mm_struct *mm)  		return 0;  	memzero((void *)pte_pg, PTRS_PER_PTE * sizeof(pte_t));  	page = virt_to_page(pte_pg); -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return 0;  	} @@ -123,7 +123,7 @@ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)  static inline void pte_free(struct mm_struct *mm, pgtable_t ptep)  { -	pgtable_page_dtor(virt_to_page(ptep)); +	pgtable_pte_page_dtor(virt_to_page(ptep));  	free_pages((unsigned long)ptep, __get_order_pte());  } diff --git a/arch/arm/include/asm/tlb.h b/arch/arm/include/asm/tlb.h index b75ea15b85c0..669474add486 100644 --- a/arch/arm/include/asm/tlb.h +++ b/arch/arm/include/asm/tlb.h @@ -44,7 +44,7 @@ static inline void __tlb_remove_table(void *_table)  static inline void  __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte, unsigned long addr)  { -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  #ifndef CONFIG_ARM_LPAE  	/* diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c index 25da9b2d9610..48c2888297dd 100644 --- a/arch/arm/mm/mmu.c +++ b/arch/arm/mm/mmu.c @@ -731,7 +731,7 @@ static void *__init late_alloc(unsigned long sz)  {  	void *ptr = (void *)__get_free_pages(GFP_PGTABLE_KERNEL, get_order(sz)); -	if (!ptr || !pgtable_page_ctor(virt_to_page(ptr))) +	if (!ptr || !pgtable_pte_page_ctor(virt_to_page(ptr)))  		BUG();  	return ptr;  } diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h index a95d1fcb7e21..b76df828e6b7 100644 --- a/arch/arm64/include/asm/tlb.h +++ b/arch/arm64/include/asm/tlb.h @@ -44,7 +44,7 @@ static inline void tlb_flush(struct mmu_gather *tlb)  static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t pte,  				  unsigned long addr)  { -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  	tlb_remove_table(tlb, pte);  } diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c index 53dc6f24cfb7..60c929f3683b 100644 --- a/arch/arm64/mm/mmu.c +++ b/arch/arm64/mm/mmu.c @@ -384,7 +384,7 @@ static phys_addr_t pgd_pgtable_alloc(int shift)  	 * folded, and if so pgtable_pmd_page_ctor() becomes nop.  	 */  	if (shift == PAGE_SHIFT) -		BUG_ON(!pgtable_page_ctor(phys_to_page(pa))); +		BUG_ON(!pgtable_pte_page_ctor(phys_to_page(pa)));  	else if (shift == PMD_SHIFT)  		BUG_ON(!pgtable_pmd_page_ctor(phys_to_page(pa))); diff --git a/arch/csky/include/asm/pgalloc.h b/arch/csky/include/asm/pgalloc.h index d089113fe41f..c7c1ed27e348 100644 --- a/arch/csky/include/asm/pgalloc.h +++ b/arch/csky/include/asm/pgalloc.h @@ -71,7 +71,7 @@ static inline pgd_t *pgd_alloc(struct mm_struct *mm)  #define __pte_free_tlb(tlb, pte, address)		\  do {							\ -	pgtable_page_dtor(pte);				\ +	pgtable_pte_page_dtor(pte);			\  	tlb_remove_page(tlb, pte);			\  } while (0) diff --git a/arch/hexagon/include/asm/pgalloc.h b/arch/hexagon/include/asm/pgalloc.h index 5a6e79e7926d..cc9be514a676 100644 --- a/arch/hexagon/include/asm/pgalloc.h +++ b/arch/hexagon/include/asm/pgalloc.h @@ -94,7 +94,7 @@ static inline void pmd_populate_kernel(struct mm_struct *mm, pmd_t *pmd,  #define __pte_free_tlb(tlb, pte, addr)		\  do {						\ -	pgtable_page_dtor((pte));		\ +	pgtable_pte_page_dtor((pte));		\  	tlb_remove_page((tlb), (pte));		\  } while (0) diff --git a/arch/m68k/include/asm/mcf_pgalloc.h b/arch/m68k/include/asm/mcf_pgalloc.h index 4399d712f6db..b34d44d666a4 100644 --- a/arch/m68k/include/asm/mcf_pgalloc.h +++ b/arch/m68k/include/asm/mcf_pgalloc.h @@ -41,7 +41,7 @@ extern inline pmd_t *pmd_alloc_kernel(pgd_t *pgd, unsigned long address)  static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t page,  				  unsigned long address)  { -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	__free_page(page);  } @@ -54,7 +54,7 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm)  	if (!page)  		return NULL; -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return NULL;  	} @@ -73,7 +73,7 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm)  static inline void pte_free(struct mm_struct *mm, struct page *page)  { -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	__free_page(page);  } diff --git a/arch/m68k/include/asm/motorola_pgalloc.h b/arch/m68k/include/asm/motorola_pgalloc.h index d04d9ba9b976..acab315c851f 100644 --- a/arch/m68k/include/asm/motorola_pgalloc.h +++ b/arch/m68k/include/asm/motorola_pgalloc.h @@ -36,7 +36,7 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)  	page = alloc_pages(GFP_KERNEL|__GFP_ZERO, 0);  	if(!page)  		return NULL; -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return NULL;  	} @@ -51,7 +51,7 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)  static inline void pte_free(struct mm_struct *mm, pgtable_t page)  { -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	cache_page(kmap(page));  	kunmap(page);  	__free_page(page); @@ -60,7 +60,7 @@ static inline void pte_free(struct mm_struct *mm, pgtable_t page)  static inline void __pte_free_tlb(struct mmu_gather *tlb, pgtable_t page,  				  unsigned long address)  { -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	cache_page(kmap(page));  	kunmap(page);  	__free_page(page); diff --git a/arch/m68k/include/asm/sun3_pgalloc.h b/arch/m68k/include/asm/sun3_pgalloc.h index 1a8ddbd0d23c..856121122b91 100644 --- a/arch/m68k/include/asm/sun3_pgalloc.h +++ b/arch/m68k/include/asm/sun3_pgalloc.h @@ -21,7 +21,7 @@ extern const char bad_pmd_string[];  #define __pte_free_tlb(tlb,pte,addr)			\  do {							\ -	pgtable_page_dtor(pte);				\ +	pgtable_pte_page_dtor(pte);			\  	tlb_remove_page((tlb), pte);			\  } while (0) diff --git a/arch/mips/include/asm/pgalloc.h b/arch/mips/include/asm/pgalloc.h index aa73cb187a07..166842337eb2 100644 --- a/arch/mips/include/asm/pgalloc.h +++ b/arch/mips/include/asm/pgalloc.h @@ -54,7 +54,7 @@ static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd)  #define __pte_free_tlb(tlb,pte,address)			\  do {							\ -	pgtable_page_dtor(pte);				\ +	pgtable_pte_page_dtor(pte);			\  	tlb_remove_page((tlb), pte);			\  } while (0) diff --git a/arch/nios2/include/asm/pgalloc.h b/arch/nios2/include/asm/pgalloc.h index 750d18d5980b..0b146d773c85 100644 --- a/arch/nios2/include/asm/pgalloc.h +++ b/arch/nios2/include/asm/pgalloc.h @@ -41,7 +41,7 @@ static inline void pgd_free(struct mm_struct *mm, pgd_t *pgd)  #define __pte_free_tlb(tlb, pte, addr)				\  	do {							\ -		pgtable_page_dtor(pte);				\ +		pgtable_pte_page_dtor(pte);			\  		tlb_remove_page((tlb), (pte));			\  	} while (0) diff --git a/arch/openrisc/include/asm/pgalloc.h b/arch/openrisc/include/asm/pgalloc.h index 787c1b9d2f6d..da12a4c38c4b 100644 --- a/arch/openrisc/include/asm/pgalloc.h +++ b/arch/openrisc/include/asm/pgalloc.h @@ -75,7 +75,7 @@ static inline struct page *pte_alloc_one(struct mm_struct *mm)  	if (!pte)  		return NULL;  	clear_page(page_address(pte)); -	if (!pgtable_page_ctor(pte)) { +	if (!pgtable_pte_page_ctor(pte)) {  		__free_page(pte);  		return NULL;  	} @@ -89,13 +89,13 @@ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)  static inline void pte_free(struct mm_struct *mm, struct page *pte)  { -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  	__free_page(pte);  }  #define __pte_free_tlb(tlb, pte, addr)	\  do {					\ -	pgtable_page_dtor(pte);		\ +	pgtable_pte_page_dtor(pte);	\  	tlb_remove_page((tlb), (pte));	\  } while (0) diff --git a/arch/powerpc/mm/pgtable-frag.c b/arch/powerpc/mm/pgtable-frag.c index a7b05214760c..ee4bd6d38602 100644 --- a/arch/powerpc/mm/pgtable-frag.c +++ b/arch/powerpc/mm/pgtable-frag.c @@ -25,7 +25,7 @@ void pte_frag_destroy(void *pte_frag)  	count = ((unsigned long)pte_frag & ~PAGE_MASK) >> PTE_FRAG_SIZE_SHIFT;  	/* We allow PTE_FRAG_NR fragments from a PTE page */  	if (atomic_sub_and_test(PTE_FRAG_NR - count, &page->pt_frag_refcount)) { -		pgtable_page_dtor(page); +		pgtable_pte_page_dtor(page);  		__free_page(page);  	}  } @@ -61,7 +61,7 @@ static pte_t *__alloc_for_ptecache(struct mm_struct *mm, int kernel)  		page = alloc_page(PGALLOC_GFP | __GFP_ACCOUNT);  		if (!page)  			return NULL; -		if (!pgtable_page_ctor(page)) { +		if (!pgtable_pte_page_ctor(page)) {  			__free_page(page);  			return NULL;  		} @@ -113,7 +113,7 @@ void pte_fragment_free(unsigned long *table, int kernel)  	BUG_ON(atomic_read(&page->pt_frag_refcount) <= 0);  	if (atomic_dec_and_test(&page->pt_frag_refcount)) {  		if (!kernel) -			pgtable_page_dtor(page); +			pgtable_pte_page_dtor(page);  		__free_page(page);  	}  } diff --git a/arch/riscv/include/asm/pgalloc.h b/arch/riscv/include/asm/pgalloc.h index f66a00d8cb19..d59ea92285ec 100644 --- a/arch/riscv/include/asm/pgalloc.h +++ b/arch/riscv/include/asm/pgalloc.h @@ -78,7 +78,7 @@ static inline void pmd_free(struct mm_struct *mm, pmd_t *pmd)  #define __pte_free_tlb(tlb, pte, buf)   \  do {                                    \ -	pgtable_page_dtor(pte);         \ +	pgtable_pte_page_dtor(pte);     \  	tlb_remove_page((tlb), pte);    \  } while (0) diff --git a/arch/s390/mm/pgalloc.c b/arch/s390/mm/pgalloc.c index 54fcdf66ae96..3dd253f81a77 100644 --- a/arch/s390/mm/pgalloc.c +++ b/arch/s390/mm/pgalloc.c @@ -210,7 +210,7 @@ unsigned long *page_table_alloc(struct mm_struct *mm)  	page = alloc_page(GFP_KERNEL);  	if (!page)  		return NULL; -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return NULL;  	} @@ -256,7 +256,7 @@ void page_table_free(struct mm_struct *mm, unsigned long *table)  		atomic_xor_bits(&page->_refcount, 3U << 24);  	} -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	__free_page(page);  } @@ -308,7 +308,7 @@ void __tlb_remove_table(void *_table)  	case 3:		/* 4K page table with pgstes */  		if (mask & 3)  			atomic_xor_bits(&page->_refcount, 3 << 24); -		pgtable_page_dtor(page); +		pgtable_pte_page_dtor(page);  		__free_page(page);  		break;  	} diff --git a/arch/sh/include/asm/pgalloc.h b/arch/sh/include/asm/pgalloc.h index 8c6341a4d807..22d968bfe9bb 100644 --- a/arch/sh/include/asm/pgalloc.h +++ b/arch/sh/include/asm/pgalloc.h @@ -29,7 +29,7 @@ static inline void pmd_populate(struct mm_struct *mm, pmd_t *pmd,  #define __pte_free_tlb(tlb,pte,addr)			\  do {							\ -	pgtable_page_dtor(pte);				\ +	pgtable_pte_page_dtor(pte);			\  	tlb_remove_page((tlb), (pte));			\  } while (0) diff --git a/arch/sparc/mm/init_64.c b/arch/sparc/mm/init_64.c index 4b099dd7a767..e6d91819da92 100644 --- a/arch/sparc/mm/init_64.c +++ b/arch/sparc/mm/init_64.c @@ -2903,7 +2903,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)  	struct page *page = alloc_page(GFP_KERNEL | __GFP_ZERO);  	if (!page)  		return NULL; -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		free_unref_page(page);  		return NULL;  	} @@ -2919,7 +2919,7 @@ static void __pte_free(pgtable_t pte)  {  	struct page *page = virt_to_page(pte); -	pgtable_page_dtor(page); +	pgtable_pte_page_dtor(page);  	__free_page(page);  } diff --git a/arch/sparc/mm/srmmu.c b/arch/sparc/mm/srmmu.c index aaebbc00d262..cc3ad64479ac 100644 --- a/arch/sparc/mm/srmmu.c +++ b/arch/sparc/mm/srmmu.c @@ -378,7 +378,7 @@ pgtable_t pte_alloc_one(struct mm_struct *mm)  	if ((pte = (unsigned long)pte_alloc_one_kernel(mm)) == 0)  		return NULL;  	page = pfn_to_page(__nocache_pa(pte) >> PAGE_SHIFT); -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return NULL;  	} @@ -389,7 +389,7 @@ void pte_free(struct mm_struct *mm, pgtable_t pte)  {  	unsigned long p; -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  	p = (unsigned long)page_address(pte);	/* Cached address (for test) */  	if (p == 0)  		BUG(); diff --git a/arch/um/include/asm/pgalloc.h b/arch/um/include/asm/pgalloc.h index 446e0c0f4018..881e76da1938 100644 --- a/arch/um/include/asm/pgalloc.h +++ b/arch/um/include/asm/pgalloc.h @@ -29,7 +29,7 @@ extern void pgd_free(struct mm_struct *mm, pgd_t *pgd);  #define __pte_free_tlb(tlb,pte, address)		\  do {							\ -	pgtable_page_dtor(pte);				\ +	pgtable_pte_page_dtor(pte);			\  	tlb_remove_page((tlb),(pte));			\  } while (0) diff --git a/arch/unicore32/include/asm/tlb.h b/arch/unicore32/include/asm/tlb.h index 10d2356bfddd..4663d8cc80ef 100644 --- a/arch/unicore32/include/asm/tlb.h +++ b/arch/unicore32/include/asm/tlb.h @@ -15,7 +15,7 @@  #define __pte_free_tlb(tlb, pte, addr)				\  	do {							\ -		pgtable_page_dtor(pte);				\ +		pgtable_pte_page_dtor(pte);			\  		tlb_remove_page((tlb), (pte));			\  	} while (0) diff --git a/arch/x86/mm/pgtable.c b/arch/x86/mm/pgtable.c index 463940faf52f..3e4b9035bb9a 100644 --- a/arch/x86/mm/pgtable.c +++ b/arch/x86/mm/pgtable.c @@ -45,7 +45,7 @@ early_param("userpte", setup_userpte);  void ___pte_free_tlb(struct mmu_gather *tlb, struct page *pte)  { -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  	paravirt_release_pte(page_to_pfn(pte));  	paravirt_tlb_remove_table(tlb, pte);  } diff --git a/arch/xtensa/include/asm/pgalloc.h b/arch/xtensa/include/asm/pgalloc.h index dd744aa450fa..1d38f0e755ba 100644 --- a/arch/xtensa/include/asm/pgalloc.h +++ b/arch/xtensa/include/asm/pgalloc.h @@ -55,7 +55,7 @@ static inline pgtable_t pte_alloc_one(struct mm_struct *mm)  	if (!pte)  		return NULL;  	page = virt_to_page(pte); -	if (!pgtable_page_ctor(page)) { +	if (!pgtable_pte_page_ctor(page)) {  		__free_page(page);  		return NULL;  	} @@ -69,7 +69,7 @@ static inline void pte_free_kernel(struct mm_struct *mm, pte_t *pte)  static inline void pte_free(struct mm_struct *mm, pgtable_t pte)  { -	pgtable_page_dtor(pte); +	pgtable_pte_page_dtor(pte);  	__free_page(pte);  }  #define pmd_pgtable(pmd) pmd_page(pmd) |