diff options
| author | Andi Kleen <andi@firstfloor.org> | 2009-05-27 21:56:54 +0200 |
|---|---|---|
| committer | H. Peter Anvin <hpa@zytor.com> | 2009-05-28 09:24:15 -0700 |
| commit | b170204ddb7844ffff62d2d537b20c0eeb97725e (patch) | |
| tree | bd7ce6426789c1b1cb6fbcb1ecd2de3adc78c008 /arch | |
| parent | 32561696c23028596f24b353d98f2e23b58f91f7 (diff) | |
| download | linux-b170204ddb7844ffff62d2d537b20c0eeb97725e.tar.bz2 | |
x86, mce: drop BKL in mce_open
BKL is not needed for anything in mce_open because it has
an own spinlock. Remove it.
[ Impact: cleanup ]
Signed-off-by: Andi Kleen <ak@linux.intel.com>
Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
Diffstat (limited to 'arch')
| -rw-r--r-- | arch/x86/kernel/cpu/mcheck/mce.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/arch/x86/kernel/cpu/mcheck/mce.c b/arch/x86/kernel/cpu/mcheck/mce.c index 18d505d80221..8ab28368bb92 100644 --- a/arch/x86/kernel/cpu/mcheck/mce.c +++ b/arch/x86/kernel/cpu/mcheck/mce.c @@ -13,7 +13,6 @@ #include <linux/ratelimit.h> #include <linux/kallsyms.h> #include <linux/rcupdate.h> -#include <linux/smp_lock.h> #include <linux/kobject.h> #include <linux/kdebug.h> #include <linux/kernel.h> @@ -791,12 +790,10 @@ static int open_exclu; /* already open exclusive? */ static int mce_open(struct inode *inode, struct file *file) { - lock_kernel(); spin_lock(&mce_state_lock); if (open_exclu || (open_count && (file->f_flags & O_EXCL))) { spin_unlock(&mce_state_lock); - unlock_kernel(); return -EBUSY; } @@ -806,7 +803,6 @@ static int mce_open(struct inode *inode, struct file *file) open_count++; spin_unlock(&mce_state_lock); - unlock_kernel(); return nonseekable_open(inode, file); } |