diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-06-05 10:51:29 +0400 |
|---|---|---|
| committer | Michael Ellerman <mpe@ellerman.id.au> | 2022-08-01 22:21:18 +1000 |
| commit | df5d4b616ee76abc97e5bd348e22659c2b095b1c (patch) | |
| tree | d4fe2607426c06b163b4ee358408779bee899d2e /arch/powerpc | |
| parent | 255b650cbec6849443ce2e0cdd187fd5e61c218c (diff) | |
| download | linux-df5d4b616ee76abc97e5bd348e22659c2b095b1c.tar.bz2 | |
powerpc/cell/axon_msi: Fix refcount leak in setup_msi_msg_address
of_get_next_parent() returns a node pointer with refcount incremented,
we should use of_node_put() on it when not need anymore.
Add missing of_node_put() in the error path to avoid refcount leak.
Fixes: ce21b3c9648a ("[CELL] add support for MSI on Axon-based Cell systems")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20220605065129.63906-1-linmq006@gmail.com
Diffstat (limited to 'arch/powerpc')
| -rw-r--r-- | arch/powerpc/platforms/cell/axon_msi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/arch/powerpc/platforms/cell/axon_msi.c b/arch/powerpc/platforms/cell/axon_msi.c index f3291e957a19..5b012abca773 100644 --- a/arch/powerpc/platforms/cell/axon_msi.c +++ b/arch/powerpc/platforms/cell/axon_msi.c @@ -223,6 +223,7 @@ static int setup_msi_msg_address(struct pci_dev *dev, struct msi_msg *msg) if (!prop) { dev_dbg(&dev->dev, "axon_msi: no msi-address-(32|64) properties found\n"); + of_node_put(dn); return -ENOENT; } |