diff options
author | Benjamin Marzinski <bmarzins@redhat.com> | 2016-11-30 17:56:14 -0600 |
---|---|---|
committer | Mike Snitzer <snitzer@redhat.com> | 2016-12-08 14:13:14 -0500 |
commit | 314c25c56c1ee5026cf99c570bdfe01847927acb (patch) | |
tree | 4604a1b45470b23a13afb18015fc60af3b8d263f /REPORTING-BUGS | |
parent | 58fc4fedee4a6e6e42f01da6ebaa0de0088fc8e3 (diff) | |
download | linux-314c25c56c1ee5026cf99c570bdfe01847927acb.tar.bz2 |
dm space map metadata: fix 'struct sm_metadata' leak on failed create
In dm_sm_metadata_create() we temporarily change the dm_space_map
operations from 'ops' (whose .destroy function deallocates the
sm_metadata) to 'bootstrap_ops' (whose .destroy function doesn't).
If dm_sm_metadata_create() fails in sm_ll_new_metadata() or
sm_ll_extend(), it exits back to dm_tm_create_internal(), which calls
dm_sm_destroy() with the intention of freeing the sm_metadata, but it
doesn't (because the dm_space_map operations is still set to
'bootstrap_ops').
Fix this by setting the dm_space_map operations back to 'ops' if
dm_sm_metadata_create() fails when it is set to 'bootstrap_ops'.
Signed-off-by: Benjamin Marzinski <bmarzins@redhat.com>
Acked-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
Cc: stable@vger.kernel.org
Diffstat (limited to 'REPORTING-BUGS')
0 files changed, 0 insertions, 0 deletions