diff options
| author | Michael Chan <michael.chan@broadcom.com> | 2017-05-30 20:03:00 -0400 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-05-30 22:37:06 -0400 |
| commit | ffe406457753a7ca2061ecc8c4d3971623066911 (patch) | |
| tree | 1c812677a8836f2dd7407fb0d135b03c7a6923da | |
| parent | a5c66b5726a9b6be4b6176e2f815321faef1e8fa (diff) | |
| download | linux-ffe406457753a7ca2061ecc8c4d3971623066911.tar.bz2 | |
bnxt_en: Fix xmit_more with BQL.
We need to write the doorbell if BQL has stopped the queue and
skb->xmit_more is set. Otherwise it is possible for the tx queue to
rot and cause tx timeout.
Fixes: 4d172f21cefe ("bnxt_en: Implement xmit_more.")
Suggested-by: Yuval Mintz <yuval.mintz@cavium.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 954758f9a177..c1cd72a5eccf 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -463,7 +463,7 @@ normal_tx: prod = NEXT_TX(prod); txr->tx_prod = prod; - if (!skb->xmit_more) + if (!skb->xmit_more || netif_xmit_stopped(txq)) bnxt_db_write(bp, txr->tx_doorbell, DB_KEY_TX | prod); tx_done: |