diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2021-12-03 15:04:18 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-12-03 14:19:54 +0000 |
| commit | f6882b8fac60f928fda51efc64274463806f956c (patch) | |
| tree | 616b1101aa670b0f390521a63bcf02e8ac53b315 | |
| parent | ab11393fd004ed048cff93076569e41bb31fe22b (diff) | |
| download | linux-f6882b8fac60f928fda51efc64274463806f956c.tar.bz2 | |
net: prestera: acl: fix return value check in prestera_acl_rule_entry_find()
rhashtable_lookup_fast() returns NULL pointer not ERR_PTR().
Return rhashtable_lookup_fast() directly to fix this.
Fixes: 47327e198d42 ("net: prestera: acl: migrate to new vTCAM api")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/marvell/prestera/prestera_acl.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_acl.c b/drivers/net/ethernet/marvell/prestera/prestera_acl.c index da0b6525ef9a..fc7f2fedafd7 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_acl.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_acl.c @@ -419,11 +419,8 @@ struct prestera_acl_rule_entry * prestera_acl_rule_entry_find(struct prestera_acl *acl, struct prestera_acl_rule_entry_key *key) { - struct prestera_acl_rule_entry *e; - - e = rhashtable_lookup_fast(&acl->acl_rule_entry_ht, key, - __prestera_acl_rule_entry_ht_params); - return IS_ERR(e) ? NULL : e; + return rhashtable_lookup_fast(&acl->acl_rule_entry_ht, key, + __prestera_acl_rule_entry_ht_params); } static int __prestera_acl_rule_entry2hw_del(struct prestera_switch *sw, |