diff options
| author | Krzysztof Kozlowski <krzk@kernel.org> | 2020-06-22 13:05:43 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-06-22 13:50:29 +0100 |
| commit | f148915f91fccd8c3df1b0bff7d1c8458cad3be5 (patch) | |
| tree | 1142cd59f6663af0bcced6e65772a83f4d90095b | |
| parent | 3d87b613d6a3c6f0980e877ab0895785a2dde581 (diff) | |
| download | linux-f148915f91fccd8c3df1b0bff7d1c8458cad3be5.tar.bz2 | |
spi: spi-fsl-dspi: Initialize completion before possible interrupt
The interrupt handler calls completion and is IRQ requested before the
completion is initialized. Logically it should be the other way.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Link: https://lore.kernel.org/r/20200622110543.5035-4-krzk@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-fsl-dspi.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index e0b30e4b1b69..91c6affe139c 100644 --- a/drivers/spi/spi-fsl-dspi.c +++ b/drivers/spi/spi-fsl-dspi.c @@ -1389,6 +1389,8 @@ static int dspi_probe(struct platform_device *pdev) goto poll_mode; } + init_completion(&dspi->xfer_done); + ret = request_threaded_irq(dspi->irq, dspi_interrupt, NULL, IRQF_SHARED, pdev->name, dspi); if (ret < 0) { @@ -1396,8 +1398,6 @@ static int dspi_probe(struct platform_device *pdev) goto out_clk_put; } - init_completion(&dspi->xfer_done); - poll_mode: if (dspi->devtype_data->trans_mode == DSPI_DMA_MODE) { |