diff options
author | Benjamin Romer <benjamin.romer@unisys.com> | 2015-03-16 13:58:26 -0400 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-23 21:53:53 +0100 |
commit | f118a39bfec6eff3ab1c1720fd734df62e012150 (patch) | |
tree | 67cdec1e710f7a498fc6656dc595dc6df3545a35 | |
parent | 61715c8b9c532e41547d47f649649c2250e98e27 (diff) | |
download | linux-f118a39bfec6eff3ab1c1720fd734df62e012150.tar.bz2 |
staging: unisys: refactor initialize_controlvm_payload_info()
Fix the CamelCased goto label:
Away => cleanup
and get rid of the NULL comparison.
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r-- | drivers/staging/unisys/visorchipset/visorchipset_main.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c index 4fe1ad1d0d3a..7956ae71e823 100644 --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c @@ -1269,26 +1269,26 @@ initialize_controlvm_payload_info(HOSTADDRESS phys_addr, u64 offset, u32 bytes, if (!info) { rc = -CONTROLVM_RESP_ERROR_PAYLOAD_INVALID; - goto Away; + goto cleanup; } memset(info, 0, sizeof(struct controlvm_payload_info)); if ((offset == 0) || (bytes == 0)) { rc = -CONTROLVM_RESP_ERROR_PAYLOAD_INVALID; - goto Away; + goto cleanup; } payload = ioremap_cache(phys_addr + offset, bytes); if (!payload) { rc = -CONTROLVM_RESP_ERROR_IOREMAP_FAILED; - goto Away; + goto cleanup; } info->offset = offset; info->bytes = bytes; info->ptr = payload; -Away: +cleanup: if (rc < 0) { - if (payload != NULL) { + if (payload) { iounmap(payload); payload = NULL; } |