diff options
| author | Danielle Ratson <danieller@nvidia.com> | 2021-11-23 09:54:46 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-11-23 11:44:31 +0000 |
| commit | ed1607e2ddf4b3196703b209428cbce3de869ff8 (patch) | |
| tree | 27f9eb756d8bfe4a3df0d6a570184482c5ca022d | |
| parent | 3b0e04140bc30f9f5c254a68013a901e5390b0a8 (diff) | |
| download | linux-ed1607e2ddf4b3196703b209428cbce3de869ff8.tar.bz2 | |
mlxsw: spectrum_router: Remove deadcode in mlxsw_sp_rif_mac_profile_find
The function idr_for_each_entry() already checks that the next entry in
the IDR is not NULL.
Therefore, checking that again in every iteration leads to deadcode.
Remove the unnecessary check in order to avoid that.
Addresses-Coverity: ("Logically dead code")
Signed-off-by: Danielle Ratson <danieller@nvidia.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c index 217e3b351dfe..98df6e8fa45f 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c @@ -8369,9 +8369,6 @@ mlxsw_sp_rif_mac_profile_find(const struct mlxsw_sp *mlxsw_sp, const char *mac) int id; idr_for_each_entry(&router->rif_mac_profiles_idr, profile, id) { - if (!profile) - continue; - if (ether_addr_equal_masked(profile->mac_prefix, mac, mlxsw_sp->mac_mask)) return profile; |