diff options
| author | Oliver Neukum <oneukum@suse.com> | 2022-02-17 14:10:44 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-18 11:05:08 +0000 |
| commit | e9da0b56fe27206b49f39805f7dcda8a89379062 (patch) | |
| tree | aa3f9228c114023a5799dd689ba8214023ca0332 | |
| parent | 2f131de361f6d0eaff17db26efdb844c178432f8 (diff) | |
| download | linux-e9da0b56fe27206b49f39805f7dcda8a89379062.tar.bz2 | |
sr9700: sanity check for packet length
A malicious device can leak heap data to user space
providing bogus frame lengths. Introduce a sanity check.
Signed-off-by: Oliver Neukum <oneukum@suse.com>
Reviewed-by: Grant Grundler <grundler@chromium.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/usb/sr9700.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index b658510cc9a4..5a53e63d33a6 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -413,7 +413,7 @@ static int sr9700_rx_fixup(struct usbnet *dev, struct sk_buff *skb) /* ignore the CRC length */ len = (skb->data[1] | (skb->data[2] << 8)) - 4; - if (len > ETH_FRAME_LEN) + if (len > ETH_FRAME_LEN || len > skb->len) return 0; /* the last packet of current skb */ |