diff options
| author | Miaoqian Lin <linmq006@gmail.com> | 2022-03-07 07:29:47 +0000 |
|---|---|---|
| committer | Lee Jones <lee.jones@linaro.org> | 2022-03-23 14:51:50 +0000 |
| commit | e84ee1a75f944a0fe3c277aaa10c426603d2b0bc (patch) | |
| tree | 3b258dbc39c182febea03ac5d53117897d7e076d | |
| parent | e4f8e06515e2ed015e36f1a1ef6ebc811f446d10 (diff) | |
| download | linux-e84ee1a75f944a0fe3c277aaa10c426603d2b0bc.tar.bz2 | |
mfd: asic3: Add missing iounmap() on error asic3_mfd_probe
Add the missing iounmap() before return from asic3_mfd_probe
in the error handling case.
Fixes: 64e8867ba809 ("mfd: tmio_mmc hardware abstraction for CNF area")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Link: https://lore.kernel.org/r/20220307072947.5369-1-linmq006@gmail.com
| -rw-r--r-- | drivers/mfd/asic3.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/drivers/mfd/asic3.c b/drivers/mfd/asic3.c index 8d58c8df46cf..56338f9dbd0b 100644 --- a/drivers/mfd/asic3.c +++ b/drivers/mfd/asic3.c @@ -906,14 +906,14 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, ret = mfd_add_devices(&pdev->dev, pdev->id, &asic3_cell_ds1wm, 1, mem, asic->irq_base, NULL); if (ret < 0) - goto out; + goto out_unmap; } if (mem_sdio && (irq >= 0)) { ret = mfd_add_devices(&pdev->dev, pdev->id, &asic3_cell_mmc, 1, mem_sdio, irq, NULL); if (ret < 0) - goto out; + goto out_unmap; } ret = 0; @@ -927,8 +927,12 @@ static int __init asic3_mfd_probe(struct platform_device *pdev, ret = mfd_add_devices(&pdev->dev, 0, asic3_cell_leds, ASIC3_NUM_LEDS, NULL, 0, NULL); } + return ret; - out: +out_unmap: + if (asic->tmio_cnf) + iounmap(asic->tmio_cnf); +out: return ret; } |