diff options
| author | Oded Gabbay <ogabbay@kernel.org> | 2020-10-19 09:06:18 +0300 |
|---|---|---|
| committer | Oded Gabbay <ogabbay@kernel.org> | 2020-11-30 10:47:30 +0200 |
| commit | e716ad3c76c8cf1722f674e43103c74cad85438f (patch) | |
| tree | afa23e6ed5da195e995ef711b0704a91bb4a46a0 | |
| parent | 3e6229965763129da2105f61cd4e0570ba53cb2b (diff) | |
| download | linux-e716ad3c76c8cf1722f674e43103c74cad85438f.tar.bz2 | |
habanalabs: make sure cs type is valid in cs_ioctl_signal_wait
Although we get a valid cs type from the callee, in case new values
will be added in the future, it is best to check the expected values
in that function.
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
| -rw-r--r-- | drivers/misc/habanalabs/common/command_submission.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/misc/habanalabs/common/command_submission.c b/drivers/misc/habanalabs/common/command_submission.c index 5ece52588ec6..8da0526d1d1f 100644 --- a/drivers/misc/habanalabs/common/command_submission.c +++ b/drivers/misc/habanalabs/common/command_submission.c @@ -1068,9 +1068,11 @@ static int cs_ioctl_signal_wait(struct hl_fpriv *hpriv, enum hl_cs_type cs_type, if (cs_type == CS_TYPE_WAIT || cs_type == CS_TYPE_SIGNAL) rc = cs_ioctl_signal_wait_create_jobs(hdev, ctx, cs, q_type, q_idx); - else + else if (cs_type == CS_TYPE_COLLECTIVE_WAIT) rc = hdev->asic_funcs->collective_wait_create_jobs(hdev, ctx, cs, q_idx, collective_engine_id); + else + rc = -EINVAL; if (rc) goto free_cs_object; |