diff options
| author | Sasha Levin <sasha.levin@oracle.com> | 2015-02-03 08:55:58 -0500 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2015-02-04 16:07:27 -0800 |
| commit | db27ebb111e9f69efece08e4cb6a34ff980f8896 (patch) | |
| tree | c8a313ca274c2246228f6176e4e21f7b2bb882d2 | |
| parent | 5201aa49b0fc12d9bf911090744ca04066bad4a7 (diff) | |
| download | linux-db27ebb111e9f69efece08e4cb6a34ff980f8896.tar.bz2 | |
net: rds: use correct size for max unacked packets and bytes
Max unacked packets/bytes is an int while sizeof(long) was used in the
sysctl table.
This means that when they were getting read we'd also leak kernel memory
to userspace along with the timeout values.
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/rds/sysctl.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/rds/sysctl.c b/net/rds/sysctl.c index c3b0cd43eb56..c173f69e1479 100644 --- a/net/rds/sysctl.c +++ b/net/rds/sysctl.c @@ -71,14 +71,14 @@ static struct ctl_table rds_sysctl_rds_table[] = { { .procname = "max_unacked_packets", .data = &rds_sysctl_max_unacked_packets, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, }, { .procname = "max_unacked_bytes", .data = &rds_sysctl_max_unacked_bytes, - .maxlen = sizeof(unsigned long), + .maxlen = sizeof(int), .mode = 0644, .proc_handler = proc_dointvec, }, |