diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-06-03 12:03:15 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-06-03 13:59:59 +0100 |
| commit | d66e033910593d99700cd9e2a75698395fcd676f (patch) | |
| tree | 451e2f05283572de4bf567801ab5bb722d2cd02e | |
| parent | 14aa731dbf464f7272bcc2f0c4f32f6de28cbe8c (diff) | |
| download | linux-d66e033910593d99700cd9e2a75698395fcd676f.tar.bz2 | |
ASoC: rsnd: check for zero node count
Most callers of_get_child_count() check that "nr" is non-zero so it
causes a static checker warning when we don't do that here. This
does not cause a problem or a crash, but having zero SSUIes does not
make sense either so let's add a check.
Addresses-Coverity: ("Unchecked return value")
Fixes: c413983eb66a ("ASoC: rsnd: adjust disabled module")
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20210603110315.81146-1-colin.king@canonical.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/sh/rcar/ssiu.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/sound/soc/sh/rcar/ssiu.c b/sound/soc/sh/rcar/ssiu.c index 5682c74bb7ff..0d8f97633dd2 100644 --- a/sound/soc/sh/rcar/ssiu.c +++ b/sound/soc/sh/rcar/ssiu.c @@ -515,6 +515,9 @@ int rsnd_ssiu_probe(struct rsnd_priv *priv) else nr = priv->ssi_nr; + if (!nr) + return -EINVAL; + ssiu = devm_kcalloc(dev, nr, sizeof(*ssiu), GFP_KERNEL); if (!ssiu) return -ENOMEM; |