diff options
| author | Cai Huoqing <caihuoqing@baidu.com> | 2021-09-15 22:57:48 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-09-16 13:35:35 +0100 |
| commit | d502933c30c6417edfc3ca2babd50343ad24b896 (patch) | |
| tree | 5983ef37003fde24e3777bcedd3a868b00f09bef | |
| parent | 95b5fc03c189e4ea5c63785274cc0b77fcc3a818 (diff) | |
| download | linux-d502933c30c6417edfc3ca2babd50343ad24b896.tar.bz2 | |
net: atl1c: Make use of the helper function dev_err_probe()
When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
And using dev_err_probe() can reduce code size, and simplify the code.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 3b51b172b317..20c032ab631b 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -2662,10 +2662,8 @@ static int atl1c_probe(struct pci_dev *pdev, const struct pci_device_id *ent) /* enable device (incl. PCI PM wakeup and hotplug setup) */ err = pci_enable_device_mem(pdev); - if (err) { - dev_err(&pdev->dev, "cannot enable PCI device\n"); - return err; - } + if (err) + return dev_err_probe(&pdev->dev, err, "cannot enable PCI device\n"); /* * The atl1c chip can DMA to 64-bit addresses, but it uses a single |