summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Biggers <ebiggers@google.com>2016-09-30 01:44:17 -0400
committerTheodore Ts'o <tytso@mit.edu>2016-09-30 01:44:17 -0400
commitcc91542ac8f29d8446ef59234796b95f0fbce09a (patch)
tree742741c73d8ec48e8950f870ce6497786e82fdc3
parente81d44778d1d57bbaef9e24c4eac7c8a7a401d40 (diff)
downloadlinux-cc91542ac8f29d8446ef59234796b95f0fbce09a.tar.bz2
ext4: do not unnecessarily null-terminate encrypted symlink data
Null-terminating the fscrypt_symlink_data on read is unnecessary because it is not string data --- it contains binary ciphertext. Signed-off-by: Eric Biggers <ebiggers@google.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/ext4/symlink.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/ext4/symlink.c b/fs/ext4/symlink.c
index 0a26cbd529c8..fdf1c6154745 100644
--- a/fs/ext4/symlink.c
+++ b/fs/ext4/symlink.c
@@ -30,7 +30,6 @@ static const char *ext4_encrypted_get_link(struct dentry *dentry,
char *caddr, *paddr = NULL;
struct fscrypt_str cstr, pstr;
struct fscrypt_symlink_data *sd;
- loff_t size = min_t(loff_t, i_size_read(inode), PAGE_SIZE - 1);
int res;
u32 max_size = inode->i_sb->s_blocksize;
@@ -49,7 +48,6 @@ static const char *ext4_encrypted_get_link(struct dentry *dentry,
if (IS_ERR(cpage))
return ERR_CAST(cpage);
caddr = page_address(cpage);
- caddr[size] = 0;
}
/* Symlink is encrypted */