diff options
| author | Andy Shevchenko <andriy.shevchenko@linux.intel.com> | 2021-12-02 22:56:12 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2021-12-06 13:49:29 +0000 |
| commit | c1a77ba466c0dd0bdf1ec2bbebb8996d7cd7b8f7 (patch) | |
| tree | 86fc8e27acc25eb1779e82249719d77ef0cda21f | |
| parent | 4db32072b8ab18a8b90191c57c74f42d00bf9991 (diff) | |
| download | linux-c1a77ba466c0dd0bdf1ec2bbebb8996d7cd7b8f7.tar.bz2 | |
ASoC: ti: davinci-mcasp: Remove unnecessary conditional
Instead of double validating of_node, return value of
the boolean property directly.
We can't remove ifdeffery, because in OF_GPIO=n cases
it might bring unwanted surprises.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
Link: https://lore.kernel.org/r/20211202205612.76216-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/ti/davinci-mcasp.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/sound/soc/ti/davinci-mcasp.c b/sound/soc/ti/davinci-mcasp.c index 81c1ccec5904..3e105caac95e 100644 --- a/sound/soc/ti/davinci-mcasp.c +++ b/sound/soc/ti/davinci-mcasp.c @@ -1870,12 +1870,10 @@ err1: static bool davinci_mcasp_have_gpiochip(struct davinci_mcasp *mcasp) { #ifdef CONFIG_OF_GPIO - if (mcasp->dev->of_node && - of_property_read_bool(mcasp->dev->of_node, "gpio-controller")) - return true; -#endif - + return of_property_read_bool(mcasp->dev->of_node, "gpio-controller"); +#else return false; +#endif } static int davinci_mcasp_get_config(struct davinci_mcasp *mcasp, |