diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2022-07-31 11:55:27 +0200 |
|---|---|---|
| committer | Lee Jones <lee@kernel.org> | 2022-09-28 16:09:50 +0100 |
| commit | becfdcd75126b20b8ec10066c5e85b34f8994ad5 (patch) | |
| tree | dcdeb8b6bb2649ea6a2cb0cf6daf094e0618b113 | |
| parent | 3fa9e4cfb55da512ebfd57336fde468830719298 (diff) | |
| download | linux-becfdcd75126b20b8ec10066c5e85b34f8994ad5.tar.bz2 | |
mfd: lp8788: Fix an error handling path in lp8788_probe()
Should an error occurs in mfd_add_devices(), some resources need to be
released, as already done in the .remove() function.
Add an error handling path and a lp8788_irq_exit() call to undo a previous
lp8788_irq_init().
Fixes: eea6b7cc53aa ("mfd: Add lp8788 mfd driver")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/18398722da9df9490722d853e4797350189ae79b.1659261275.git.christophe.jaillet@wanadoo.fr
| -rw-r--r-- | drivers/mfd/lp8788.c | 12 |
1 files changed, 10 insertions, 2 deletions
diff --git a/drivers/mfd/lp8788.c b/drivers/mfd/lp8788.c index c223d2c6a363..998e8cc408a0 100644 --- a/drivers/mfd/lp8788.c +++ b/drivers/mfd/lp8788.c @@ -195,8 +195,16 @@ static int lp8788_probe(struct i2c_client *cl, const struct i2c_device_id *id) if (ret) return ret; - return mfd_add_devices(lp->dev, -1, lp8788_devs, - ARRAY_SIZE(lp8788_devs), NULL, 0, NULL); + ret = mfd_add_devices(lp->dev, -1, lp8788_devs, + ARRAY_SIZE(lp8788_devs), NULL, 0, NULL); + if (ret) + goto err_exit_irq; + + return 0; + +err_exit_irq: + lp8788_irq_exit(lp); + return ret; } static int lp8788_remove(struct i2c_client *cl) |