diff options
| author | Rafał Miłecki <rafal@milecki.pl> | 2016-11-20 16:09:30 +0100 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2016-11-22 11:09:48 -0800 |
| commit | bd5d21310133921021d78995ad6346f908483124 (patch) | |
| tree | 938f95d72306b0b5a41f4ae55a85014a159fd7ba | |
| parent | 64ad46379fcf14f437553f654d1adcd3d0e0d7f9 (diff) | |
| download | linux-bd5d21310133921021d78995ad6346f908483124.tar.bz2 | |
mtd: bcm47xxpart: fix parsing first block after aligned TRX
After parsing TRX we should skip to the first block placed behind it.
Our code was working only with TRX with length not aligned to the
blocksize. In other cases (length aligned) it was missing the block
places right after TRX.
This fixes calculation and simplifies the comment.
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
| -rw-r--r-- | drivers/mtd/bcm47xxpart.c | 10 |
1 files changed, 4 insertions, 6 deletions
diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c index 377947580203..283ff7e17a0f 100644 --- a/drivers/mtd/bcm47xxpart.c +++ b/drivers/mtd/bcm47xxpart.c @@ -229,12 +229,10 @@ static int bcm47xxpart_parse(struct mtd_info *master, last_trx_part = curr_part - 1; - /* - * We have whole TRX scanned, skip to the next part. Use - * roundown (not roundup), as the loop will increase - * offset in next step. - */ - offset = rounddown(offset + trx->length, blocksize); + /* Jump to the end of TRX */ + offset = roundup(offset + trx->length, blocksize); + /* Next loop iteration will increase the offset */ + offset -= blocksize; continue; } |