diff options
| author | Xiaoke Wang <xkernel.wang@foxmail.com> | 2022-02-18 10:19:39 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2022-02-18 12:00:44 +0000 |
| commit | b352c3465bb808ab700d03f5bac2f7a6f37c5350 (patch) | |
| tree | b690368eaf5e89449834e586359dc52e73cc4653 | |
| parent | a1cdec57e03a1352e92fbbe7974039dda4efcec0 (diff) | |
| download | linux-b352c3465bb808ab700d03f5bac2f7a6f37c5350.tar.bz2 | |
net: ll_temac: check the return value of devm_kmalloc()
devm_kmalloc() returns a pointer to allocated memory on success, NULL
on failure. While lp->indirect_lock is allocated by devm_kmalloc()
without proper check. It is better to check the value of it to
prevent potential wrong memory access.
Fixes: f14f5c11f051 ("net: ll_temac: Support indirect_mutex share within TEMAC IP")
Signed-off-by: Xiaoke Wang <xkernel.wang@foxmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/ethernet/xilinx/ll_temac_main.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/ethernet/xilinx/ll_temac_main.c b/drivers/net/ethernet/xilinx/ll_temac_main.c index b900ab5aef2a..64c7e26c3b75 100644 --- a/drivers/net/ethernet/xilinx/ll_temac_main.c +++ b/drivers/net/ethernet/xilinx/ll_temac_main.c @@ -1433,6 +1433,8 @@ static int temac_probe(struct platform_device *pdev) lp->indirect_lock = devm_kmalloc(&pdev->dev, sizeof(*lp->indirect_lock), GFP_KERNEL); + if (!lp->indirect_lock) + return -ENOMEM; spin_lock_init(lp->indirect_lock); } |