summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorXiongfeng Wang <xiongfeng.wang@linaro.org>2018-01-09 19:58:18 +0800
committerDavid S. Miller <davem@davemloft.net>2018-01-10 15:06:14 -0500
commitb0d55b5bc77755501be9de2c935d106ff8dba9ac (patch)
treea0835cc408812f6c759722f2471188bfa9754f8c
parentaf60d61fa846725566f4a876ae04f891bdff1c7a (diff)
downloadlinux-b0d55b5bc77755501be9de2c935d106ff8dba9ac.tar.bz2
caif_usb: use strlcpy() instead of strncpy()
gcc-8 reports net/caif/caif_usb.c: In function 'cfusbl_device_notify': ./include/linux/string.h:245:9: warning: '__builtin_strncpy' output may be truncated copying 15 bytes from a string of length 15 [-Wstringop-truncation] The compiler require that the input param 'len' of strncpy() should be greater than the length of the src string, so that '\0' is copied as well. We can just use strlcpy() to avoid this warning. Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/caif/caif_usb.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c
index 5cd44f001f64..1a082a946045 100644
--- a/net/caif/caif_usb.c
+++ b/net/caif/caif_usb.c
@@ -176,9 +176,7 @@ static int cfusbl_device_notify(struct notifier_block *me, unsigned long what,
dev_add_pack(&caif_usb_type);
pack_added = true;
- strncpy(layer->name, dev->name,
- sizeof(layer->name) - 1);
- layer->name[sizeof(layer->name) - 1] = 0;
+ strlcpy(layer->name, dev->name, sizeof(layer->name));
return 0;
}