diff options
| author | Linus Walleij <linus.walleij@linaro.org> | 2015-12-21 22:45:55 +0100 |
|---|---|---|
| committer | Linus Walleij <linus.walleij@linaro.org> | 2016-01-25 18:02:26 +0100 |
| commit | a80bb4c9ec200ab4fc3ad502bf80e00ca5db12a7 (patch) | |
| tree | 3828d08fab52b54a922fa00901ac7076a98b0e40 | |
| parent | a4ce4b8dae68e7233ba699f10e9c120df31f5824 (diff) | |
| download | linux-a80bb4c9ec200ab4fc3ad502bf80e00ca5db12a7.tar.bz2 | |
unicore: gpio: Be sure to clamp return value
As we want gpio_chip .get() calls to be able to return negative
error codes and propagate to drivers, we need to go over all
drivers and make sure their return values are clamped to [0,1].
We do this by using the ret = !!(val) design pattern.
Cc: Guan Xuetao <gxt@mprc.pku.edu.cn>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
| -rw-r--r-- | arch/unicore32/kernel/gpio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/unicore32/kernel/gpio.c b/arch/unicore32/kernel/gpio.c index cb12ec39552c..5ab23794ea17 100644 --- a/arch/unicore32/kernel/gpio.c +++ b/arch/unicore32/kernel/gpio.c @@ -52,7 +52,7 @@ device_initcall(puv3_gpio_leds_init); static int puv3_gpio_get(struct gpio_chip *chip, unsigned offset) { - return readl(GPIO_GPLR) & GPIO_GPIO(offset); + return !!(readl(GPIO_GPLR) & GPIO_GPIO(offset)); } static void puv3_gpio_set(struct gpio_chip *chip, unsigned offset, int value) |