diff options
| author | Christopher James Halse Rogers <christopher.halse.rogers@canonical.com> | 2017-03-29 15:00:54 +1100 |
|---|---|---|
| committer | Alex Deucher <alexander.deucher@amd.com> | 2017-04-07 12:20:38 -0400 |
| commit | a294043b2fbd8de69d161457ed0c7a4026bbfa5a (patch) | |
| tree | 15628e9e2ad0963dc7b2faf9a9ab5b5e5fae57f2 | |
| parent | 0168778115687486575a6831df865dbc4f5369fe (diff) | |
| download | linux-a294043b2fbd8de69d161457ed0c7a4026bbfa5a.tar.bz2 | |
drm/radeon: Fail fb creation from imported dma-bufs.
Any use of the framebuffer will migrate it to VRAM, which is not sensible for
an imported dma-buf.
v2: Use DRM_DEBUG_KMS to prevent userspace accidentally spamming dmesg.
Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Christopher James Halse Rogers <christopher.halse.rogers@canonical.com>
CC: amd-gfx@lists.freedesktop.org
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
| -rw-r--r-- | drivers/gpu/drm/radeon/radeon_display.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c index 146297a702ab..e765a638f90c 100644 --- a/drivers/gpu/drm/radeon/radeon_display.c +++ b/drivers/gpu/drm/radeon/radeon_display.c @@ -1354,6 +1354,12 @@ radeon_user_framebuffer_create(struct drm_device *dev, return ERR_PTR(-ENOENT); } + /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */ + if (obj->import_attach) { + DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n"); + return ERR_PTR(-EINVAL); + } + radeon_fb = kzalloc(sizeof(*radeon_fb), GFP_KERNEL); if (radeon_fb == NULL) { drm_gem_object_unreference_unlocked(obj); |