diff options
| author | Stephen Boyd <swboyd@chromium.org> | 2020-04-23 13:34:16 -0700 |
|---|---|---|
| committer | Bartosz Golaszewski <bgolaszewski@baylibre.com> | 2020-04-24 09:10:01 +0200 |
| commit | 9784c9963feccd8dede924dbc0f8b1c64506e646 (patch) | |
| tree | c7378f6790b977625d708bec4a529f3022d7ae5c | |
| parent | aa58a21ae37894d456a2f91a37e9fd71ad4aa27e (diff) | |
| download | linux-9784c9963feccd8dede924dbc0f8b1c64506e646.tar.bz2 | |
gpiolib: devprop: Warn if gpio-line-names is too long
Some DT authors (including myself) have messed up the length of
gpio-line-names and made it longer than it should be. Add a warning here
so that developers can figure out that they've messed up their DT and
should fix it.
Cc: Alexandru M Stan <amstan@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
| -rw-r--r-- | drivers/gpio/gpiolib-devprop.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/gpio/gpiolib-devprop.c b/drivers/gpio/gpiolib-devprop.c index 53781b253986..26741032fa9e 100644 --- a/drivers/gpio/gpiolib-devprop.c +++ b/drivers/gpio/gpiolib-devprop.c @@ -37,8 +37,11 @@ void devprop_gpiochip_set_names(struct gpio_chip *chip, if (count < 0) return; - if (count > gdev->ngpio) + if (count > gdev->ngpio) { + dev_warn(&gdev->dev, "gpio-line-names is length %d but should be at most length %d", + count, gdev->ngpio); count = gdev->ngpio; + } names = kcalloc(count, sizeof(*names), GFP_KERNEL); if (!names) |