diff options
| author | Lv Ruyi <lv.ruyi@zte.com.cn> | 2022-04-25 09:09:47 +0000 |
|---|---|---|
| committer | Dmitry Baryshkov <dmitry.baryshkov@linaro.org> | 2022-05-02 02:07:08 +0300 |
| commit | 95093595914c17f32e1d6228b4db06fab8cebd35 (patch) | |
| tree | ad7edd655632555c7bd50f0af3065315da909747 | |
| parent | 3e9c146f4997e32d257215b0036b2425c6053ffe (diff) | |
| download | linux-95093595914c17f32e1d6228b4db06fab8cebd35.tar.bz2 | |
drm/msm/dpu: fix error check return value of irq_of_parse_and_map()
The irq_of_parse_and_map() function returns 0 on failure, and does not
return a negative value anyhow, so never enter this conditional branch.
Fixes: 25fdd5933e4c ("drm/msm: Add SDM845 DPU support")
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Patchwork: https://patchwork.freedesktop.org/patch/483291/
Link: https://lore.kernel.org/r/20220425090947.3498897-1-lv.ruyi@zte.com.cn
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
| -rw-r--r-- | drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index c683cab0dc31..3316b964d4f3 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -1183,9 +1183,9 @@ static int dpu_kms_init(struct drm_device *ddev) priv->kms = &dpu_kms->base; irq = irq_of_parse_and_map(dpu_kms->pdev->dev.of_node, 0); - if (irq < 0) { - DPU_ERROR("failed to get irq: %d\n", irq); - return irq; + if (!irq) { + DPU_ERROR("failed to get irq\n"); + return -EINVAL; } dpu_kms->base.irq = irq; |