diff options
| author | Tom Zanussi <tzanussi@gmail.com> | 2009-12-15 02:53:37 -0600 |
|---|---|---|
| committer | Ingo Molnar <mingo@elte.hu> | 2009-12-15 10:31:32 +0100 |
| commit | 8f11d85a0e7e9025acea7493e6864089c8b52f42 (patch) | |
| tree | 9de666c26df99502cae53f3912614d18fba22283 | |
| parent | a3a7cb7bb1d7bd989982314cf6f90ec392890006 (diff) | |
| download | linux-8f11d85a0e7e9025acea7493e6864089c8b52f42.tar.bz2 | |
perf trace/scripting: Check return val of perl_run()
The return value from perl_run() is currently ignored, but it
should be checked and used to exit perf if there are problems
loading the script.
Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
Cc: fweisbec@gmail.com
Cc: rostedt@goodmis.org
LKML-Reference: <1260867220-15699-4-git-send-email-tzanussi@gmail.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
| -rw-r--r-- | tools/perf/util/trace-event-perl.c | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/tools/perf/util/trace-event-perl.c b/tools/perf/util/trace-event-perl.c index 6f10e7602452..6d6d76b8a21e 100644 --- a/tools/perf/util/trace-event-perl.c +++ b/tools/perf/util/trace-event-perl.c @@ -379,7 +379,11 @@ static int perl_start_script(const char *script, int argc, const char **argv) goto error; } - perl_run(my_perl); + if (perl_run(my_perl)) { + err = -1; + goto error; + } + if (SvTRUE(ERRSV)) { err = -1; goto error; |