summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorVladis Dronov <vdronov@redhat.com>2017-09-04 16:00:50 +0200
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>2017-09-04 16:00:50 +0200
commit8e75f7a7a00461ef6d91797a60b606367f6e344d (patch)
tree004a1d393f4c0b7a771540e54f566c522782f93d
parentb9a58de545858ac9ee67745cdea6d94cc322938e (diff)
downloadlinux-8e75f7a7a00461ef6d91797a60b606367f6e344d.tar.bz2
video: fbdev: aty: do not leak uninitialized padding in clk to userspace
'clk' is copied to a userland with padding byte(s) after 'vclk_post_div' field unitialized, leaking data from the stack. Fix this ensuring all of 'clk' is initialized to zero. References: https://github.com/torvalds/linux/pull/441 Reported-by: sohu0106 <sohu0106@126.com> Signed-off-by: Vladis Dronov <vdronov@redhat.com> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
-rw-r--r--drivers/video/fbdev/aty/atyfb_base.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/fbdev/aty/atyfb_base.c b/drivers/video/fbdev/aty/atyfb_base.c
index f49efb2fb75f..3ec72f19114b 100644
--- a/drivers/video/fbdev/aty/atyfb_base.c
+++ b/drivers/video/fbdev/aty/atyfb_base.c
@@ -1855,7 +1855,7 @@ static int atyfb_ioctl(struct fb_info *info, u_int cmd, u_long arg)
#if defined(DEBUG) && defined(CONFIG_FB_ATY_CT)
case ATYIO_CLKR:
if (M64_HAS(INTEGRATED)) {
- struct atyclk clk;
+ struct atyclk clk = { 0 };
union aty_pll *pll = &par->pll;
u32 dsp_config = pll->ct.dsp_config;
u32 dsp_on_off = pll->ct.dsp_on_off;