summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDaniel Vetter <daniel.vetter@ffwll.ch>2019-02-21 16:59:51 +0100
committerHans de Goede <hdegoede@redhat.com>2019-03-11 17:31:00 +0100
commit893ded36e06de1f9826b6303b5733fbc4990a97a (patch)
tree00d85dd1ed6d9169920e4705d0e953b4c1b0cf35
parenta34ced4541cc453de520a0db47757f4b99983bf6 (diff)
downloadlinux-893ded36e06de1f9826b6303b5733fbc4990a97a.tar.bz2
staging/vboxvideo: Another FIXME item
Found while grepping around. Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Hans de Goede <hdegoede@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Sam Ravnborg <sam@ravnborg.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Cc: Liviu Dudau <liviu.dudau@arm.com> Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://patchwork.freedesktop.org/patch/msgid/20190221155951.19855-1-daniel.vetter@ffwll.ch
-rw-r--r--drivers/staging/vboxvideo/vbox_irq.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/staging/vboxvideo/vbox_irq.c b/drivers/staging/vboxvideo/vbox_irq.c
index 195484713365..89944134ea86 100644
--- a/drivers/staging/vboxvideo/vbox_irq.c
+++ b/drivers/staging/vboxvideo/vbox_irq.c
@@ -123,6 +123,11 @@ static void vbox_update_mode_hints(struct vbox_private *vbox)
validate_or_set_position_hints(vbox);
drm_modeset_lock_all(dev);
+ /*
+ * FIXME: this needs to use drm_connector_list_iter and some real
+ * locking for the actual data it changes, not the deprecated
+ * drm_modeset_lock_all() shotgun approach.
+ */
list_for_each_entry(connector, &dev->mode_config.connector_list, head) {
vbox_conn = to_vbox_connector(connector);