diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-05-09 09:59:54 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-05-20 14:51:28 +0200 |
| commit | 88a4711e7973836e3802e75e954e3cd1b07b3fba (patch) | |
| tree | 9d1962001449928ab3663616306673c3bdbf3c8e | |
| parent | 9972311643ac9c8f550272410a0cd4d6a2671eee (diff) | |
| download | linux-88a4711e7973836e3802e75e954e3cd1b07b3fba.tar.bz2 | |
media: atomisp: add -dDEBUG when building this driver
This driver still has lots of issues. Let's enable debug
there inconditionally, as we need more information in order
to address the pending issues.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
| -rw-r--r-- | drivers/staging/media/atomisp/Makefile | 3 | ||||
| -rw-r--r-- | drivers/staging/media/atomisp/pci/atomisp_fops.c | 1 |
2 files changed, 4 insertions, 0 deletions
diff --git a/drivers/staging/media/atomisp/Makefile b/drivers/staging/media/atomisp/Makefile index d166b5f614e8..c032444a4db6 100644 --- a/drivers/staging/media/atomisp/Makefile +++ b/drivers/staging/media/atomisp/Makefile @@ -5,6 +5,9 @@ obj-$(CONFIG_INTEL_ATOMISP) += i2c/ obj-$(CONFIG_INTEL_ATOMISP) += platform/ obj-$(CONFIG_VIDEO_ATOMISP) += atomisp.o +# While on staging, keep debug enabled +DEFINES += -DDEBUG + atomisp = $(srctree)/drivers/staging/media/atomisp/ # SPDX-License-Identifier: GPL-2.0 diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c index 2b855e7b61c8..667d6f7d1d5e 100644 --- a/drivers/staging/media/atomisp/pci/atomisp_fops.c +++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c @@ -785,6 +785,7 @@ static int atomisp_open(struct file *file) asd->subdev.devnode = vdev; /* Deferred firmware loading case. */ if (isp->css_env.isp_css_fw.bytes == 0) { + dev_err(isp->dev, "Deferred firmware load.\n"); isp->firmware = atomisp_load_firmware(isp); if (!isp->firmware) { dev_err(isp->dev, "Failed to load ISP firmware.\n"); |