diff options
| author | Vlad Buslov <vladbu@mellanox.com> | 2019-06-12 10:14:35 +0300 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-06-12 09:28:05 -0700 |
| commit | 7a096d579e8e2bd8b8ff34d5ef3093cd9bf3f13b (patch) | |
| tree | 56b90bb69ee6b9239f3d78887cc0cc8e3fa31465 | |
| parent | 758a0a4d60ab8a5bfed1e8365c6faa00d8b8dbd5 (diff) | |
| download | linux-7a096d579e8e2bd8b8ff34d5ef3093cd9bf3f13b.tar.bz2 | |
net: sched: ingress: set 'unlocked' flag for Qdisc ops
To remove rtnl lock dependency in tc filter update API when using ingress
Qdisc, set QDISC_CLASS_OPS_DOIT_UNLOCKED flag in ingress Qdisc_class_ops.
Ingress Qdisc ops don't require any modifications to be used without rtnl
lock on tc filter update path. Ingress implementation never changes its
q->block and only releases it when Qdisc is being destroyed. This means it
is enough for RTM_{NEWTFILTER|DELTFILTER|GETTFILTER} message handlers to
hold ingress Qdisc reference while using it without relying on rtnl lock
protection. Unlocked Qdisc ops support is already implemented in filter
update path by unlocked cls API patch set.
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/sched/sch_ingress.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/sched/sch_ingress.c b/net/sched/sch_ingress.c index 0f65f617756b..d5382554e281 100644 --- a/net/sched/sch_ingress.c +++ b/net/sched/sch_ingress.c @@ -114,6 +114,7 @@ nla_put_failure: } static const struct Qdisc_class_ops ingress_class_ops = { + .flags = QDISC_CLASS_OPS_DOIT_UNLOCKED, .leaf = ingress_leaf, .find = ingress_find, .walk = ingress_walk, |