diff options
| author | Roland Dreier <roland@purestorage.com> | 2017-08-29 10:34:44 -0700 |
|---|---|---|
| committer | Doug Ledford <dledford@redhat.com> | 2017-08-31 08:35:07 -0400 |
| commit | 79364227e6b4923478e99d8480d62482b588ef84 (patch) | |
| tree | 614e7d1eb902b63a923bd0d0b5add7156b8a99f4 | |
| parent | c76161181193985087cd716fdf69b5cb6cf9ee85 (diff) | |
| download | linux-79364227e6b4923478e99d8480d62482b588ef84.tar.bz2 | |
IB/core: Add might_sleep() annotation to ib_init_ah_from_wc()
For RoCE, ib_init_ah_from_wc() can follow the path
ib_init_ah_from_wc() ->
rdma_addr_find_l2_eth_by_grh() ->
rdma_resolve_ip()
and rdma_resolve_ip() will sleep in kzalloc() and wait_for_completion().
However, developers will not see any warnings if they use ib_init_ah_from_wc()
in an atomic context and test only on IB, because the function doesn't
sleep in that case.
Add a might_sleep() so that lockdep will catch bugs no matter what hardware is
used to test.
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Doug Ledford <dledford@redhat.com>
| -rw-r--r-- | drivers/infiniband/core/verbs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/infiniband/core/verbs.c b/drivers/infiniband/core/verbs.c index ecb6c395f19b..ee9e27dc799b 100644 --- a/drivers/infiniband/core/verbs.c +++ b/drivers/infiniband/core/verbs.c @@ -468,6 +468,8 @@ int ib_init_ah_from_wc(struct ib_device *device, u8 port_num, union ib_gid dgid; union ib_gid sgid; + might_sleep(); + memset(ah_attr, 0, sizeof *ah_attr); ah_attr->type = rdma_ah_find_type(device, port_num); if (rdma_cap_eth_ah(device, port_num)) { |