diff options
| author | Eric Biggers <ebiggers@google.com> | 2020-12-02 18:20:33 -0800 |
|---|---|---|
| committer | Eric Biggers <ebiggers@google.com> | 2020-12-02 18:25:01 -0800 |
| commit | 65f62515e9e55056a06c14a19150c1ea7760e2af (patch) | |
| tree | dcf121b1c7d1b9a3baf7322ce77e6edba04bb3ad | |
| parent | 4a4b8721f1a5e4b01e45b3153c68d5a1014b25de (diff) | |
| download | linux-65f62515e9e55056a06c14a19150c1ea7760e2af.tar.bz2 | |
ext4: remove ext4_dir_open()
Since encrypted directories can be opened and searched without their key
being available, and each readdir and ->lookup() tries to set up the
key, trying to set up the key in ->open() too isn't really useful.
Just remove it so that directories don't need an ->open() method
anymore, and so that we eliminate a use of fscrypt_get_encryption_info()
(which I'd like to stop exporting to filesystems).
Reviewed-by: Andreas Dilger <adilger@dilger.ca>
Link: https://lore.kernel.org/r/20201203022041.230976-2-ebiggers@kernel.org
Signed-off-by: Eric Biggers <ebiggers@google.com>
| -rw-r--r-- | fs/ext4/dir.c | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index ca50c90adc4c..16bfbdd5007c 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -616,13 +616,6 @@ finished: return 0; } -static int ext4_dir_open(struct inode * inode, struct file * filp) -{ - if (IS_ENCRYPTED(inode)) - return fscrypt_get_encryption_info(inode) ? -EACCES : 0; - return 0; -} - static int ext4_release_dir(struct inode *inode, struct file *filp) { if (filp->private_data) @@ -664,7 +657,6 @@ const struct file_operations ext4_dir_operations = { .compat_ioctl = ext4_compat_ioctl, #endif .fsync = ext4_sync_file, - .open = ext4_dir_open, .release = ext4_release_dir, }; |