diff options
| author | Lars-Peter Clausen <lars@metafoo.de> | 2014-11-10 22:41:44 +0100 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2014-11-18 15:26:05 +0000 |
| commit | 65c72efd1ea370f0311a5d89754996fff9fc0747 (patch) | |
| tree | e4b339c1b7c16fa1132ffdb678dcb7aaa9472579 | |
| parent | 35480e3536cdab1ee1976675e798f16d707f5356 (diff) | |
| download | linux-65c72efd1ea370f0311a5d89754996fff9fc0747.tar.bz2 | |
ASoC: mpc5200_dma: Don't overwrite ac97 device private_data
The mpc5200_dma overwrites the private_data field of the CODEC's AC'97
device with the DMA drivers private data, but never actually reads it again.
Given that the private_data field is supposed to be owned by the AC'97
driver, overwriting it may cause undefined behavior. This patch removes the
code that overwrites the field from the driver.
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/fsl/mpc5200_dma.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sound/soc/fsl/mpc5200_dma.c b/sound/soc/fsl/mpc5200_dma.c index f2b5d756b1f3..0b82e209b6e3 100644 --- a/sound/soc/fsl/mpc5200_dma.c +++ b/sound/soc/fsl/mpc5200_dma.c @@ -327,9 +327,6 @@ static int psc_dma_new(struct snd_soc_pcm_runtime *rtd) goto capture_alloc_err; } - if (rtd->codec->ac97) - rtd->codec->ac97->private_data = psc_dma; - return 0; capture_alloc_err: |