summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorGustavo A. R. Silva <gustavo@embeddedor.com>2018-07-29 16:11:59 -0400
committerTheodore Ts'o <tytso@mit.edu>2018-07-29 16:11:59 -0400
commit62bbdd9974678513fee113f09f6b672623521179 (patch)
treed92acb845a765a1c2b5f2a4121eb235c2add9610
parent21ac738ede0b49004b53b4a44fe3df7bb4a78280 (diff)
downloadlinux-62bbdd9974678513fee113f09f6b672623521179.tar.bz2
ext4: use swap macro in mext_page_double_lock
Make use of the swap macro and remove unnecessary variable *tmp*. This makes the code easier to read and maintain. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu>
-rw-r--r--fs/ext4/move_extent.c4
1 files changed, 1 insertions, 3 deletions
diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 8e17efdcbf11..a409ff70d67b 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -134,9 +134,7 @@ mext_page_double_lock(struct inode *inode1, struct inode *inode2,
mapping[0] = inode1->i_mapping;
mapping[1] = inode2->i_mapping;
} else {
- pgoff_t tmp = index1;
- index1 = index2;
- index2 = tmp;
+ swap(index1, index2);
mapping[0] = inode2->i_mapping;
mapping[1] = inode1->i_mapping;
}