summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorLiu Shixin <liushixin2@huawei.com>2022-11-22 10:16:12 +0800
committerVinod Koul <vkoul@kernel.org>2023-01-18 22:16:04 +0530
commit596b53ccc36a546ab28e8897315c5b4d1d5a0200 (patch)
tree9cab87b9bf693902a79504db8315a319b97d3fd0
parent1417f59ac0b02130ee56c0c50794b9b257be3d17 (diff)
downloadlinux-596b53ccc36a546ab28e8897315c5b4d1d5a0200.tar.bz2
dmaengine: xilinx_dma: call of_node_put() when breaking out of for_each_child_of_node()
Since for_each_child_of_node() will increase the refcount of node, we need to call of_node_put() manually when breaking out of the iteration. Fixes: 9cd4360de609 ("dma: Add Xilinx AXI Video Direct Memory Access Engine driver support") Signed-off-by: Liu Shixin <liushixin2@huawei.com> Acked-by: Peter Korsgaard <peter@korsgaard.com> Link: https://lore.kernel.org/r/20221122021612.1908866-1-liushixin2@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
-rw-r--r--drivers/dma/xilinx/xilinx_dma.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
index a8d23cdf883e..ac09f0e5f58d 100644
--- a/drivers/dma/xilinx/xilinx_dma.c
+++ b/drivers/dma/xilinx/xilinx_dma.c
@@ -3143,8 +3143,10 @@ static int xilinx_dma_probe(struct platform_device *pdev)
/* Initialize the channels */
for_each_child_of_node(node, child) {
err = xilinx_dma_child_probe(xdev, child);
- if (err < 0)
+ if (err < 0) {
+ of_node_put(child);
goto error;
+ }
}
if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {