diff options
| author | Benjamin Romer <benjamin.romer@unisys.com> | 2015-03-16 13:58:29 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-23 21:53:54 +0100 |
| commit | 55b33413b882570b4790e1fada44060d6f7e5cfa (patch) | |
| tree | fa7edde7ac1c34bf56654db6b4246e695ea39929 | |
| parent | cafefc0ca1a36fa917a9cf1bea6ea4e9e05db8f1 (diff) | |
| download | linux-55b33413b882570b4790e1fada44060d6f7e5cfa.tar.bz2 | |
staging: unisys: refactor parahotplug_process_list()
Simplify the code a little and shorten the indentation levels by
reversing the check for time_after_eq().
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/staging/unisys/visorchipset/visorchipset_main.c | 22 |
1 files changed, 12 insertions, 10 deletions
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c b/drivers/staging/unisys/visorchipset/visorchipset_main.c index a32d092b38d2..e25bf80fe653 100644 --- a/drivers/staging/unisys/visorchipset/visorchipset_main.c +++ b/drivers/staging/unisys/visorchipset/visorchipset_main.c @@ -1535,15 +1535,17 @@ parahotplug_process_list(void) list_for_each_safe(pos, tmp, &Parahotplug_request_list) { struct parahotplug_request *req = list_entry(pos, struct parahotplug_request, list); - if (time_after_eq(jiffies, req->expiration)) { - list_del(pos); - if (req->msg.hdr.flags.response_expected) - controlvm_respond_physdev_changestate( - &req->msg.hdr, - CONTROLVM_RESP_ERROR_DEVICE_UDEV_TIMEOUT, - req->msg.cmd.device_change_state.state); - parahotplug_request_destroy(req); - } + + if (!time_after_eq(jiffies, req->expiration)) + continue; + + list_del(pos); + if (req->msg.hdr.flags.response_expected) + controlvm_respond_physdev_changestate( + &req->msg.hdr, + CONTROLVM_RESP_ERROR_DEVICE_UDEV_TIMEOUT, + req->msg.cmd.device_change_state.state); + parahotplug_request_destroy(req); } spin_unlock(&Parahotplug_request_list_lock); @@ -1621,7 +1623,7 @@ parahotplug_process_message(struct controlvm_message *inmsg) * indicated it's done. */ spin_lock(&Parahotplug_request_list_lock); - list_add_tail(&(req->list), &Parahotplug_request_list); + list_add_tail(&req->list, &Parahotplug_request_list); spin_unlock(&Parahotplug_request_list_lock); parahotplug_request_kickoff(req); |