diff options
| author | Steve French <stfrench@microsoft.com> | 2021-06-22 14:07:36 -0500 |
|---|---|---|
| committer | Steve French <stfrench@microsoft.com> | 2021-06-23 13:06:35 -0500 |
| commit | 4c4a525ae590623eb3ba667151194a024e643ffd (patch) | |
| tree | 7f86704ac6b70b13cf842330a702b7fa005a57a4 | |
| parent | 2438c0bd598b5547333e0e3c1581da078569f130 (diff) | |
| download | linux-4c4a525ae590623eb3ba667151194a024e643ffd.tar.bz2 | |
cifs: remove two cases where rc is set unnecessarily in sid_to_id
In both these cases sid_to_id unconditionally returned success, and
used the default uid/gid for the mount, so setting rc is confusing
and simply gets overwritten (set to 0) later in the function.
Addresses-Coverity: 1491672 ("Unused value")
Signed-off-by: Steve French <stfrench@microsoft.com>
| -rw-r--r-- | fs/cifs/cifsacl.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c index 3898a9e6d3c6..5ec5d9d24032 100644 --- a/fs/cifs/cifsacl.c +++ b/fs/cifs/cifsacl.c @@ -397,7 +397,6 @@ try_upcall_to_get_id: saved_cred = override_creds(root_cred); sidkey = request_key(&cifs_idmap_key_type, sidstr, ""); if (IS_ERR(sidkey)) { - rc = -EINVAL; cifs_dbg(FYI, "%s: Can't map SID %s to a %cid\n", __func__, sidstr, sidtype == SIDOWNER ? 'u' : 'g'); goto out_revert_creds; @@ -410,7 +409,6 @@ try_upcall_to_get_id: */ BUILD_BUG_ON(sizeof(uid_t) != sizeof(gid_t)); if (sidkey->datalen != sizeof(uid_t)) { - rc = -EIO; cifs_dbg(FYI, "%s: Downcall contained malformed key (datalen=%hu)\n", __func__, sidkey->datalen); key_invalidate(sidkey); |