diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2022-07-05 22:51:43 +0200 |
|---|---|---|
| committer | Herbert Xu <herbert@gondor.apana.org.au> | 2022-07-15 16:43:21 +0800 |
| commit | 35b22c19daa1bbe77dce2f7f776c0cf2acff1f00 (patch) | |
| tree | d0d69237153c1679294adc03d62e97eea45dfe31 | |
| parent | 8ce715e711659322a6e05cad154aa1355bb2e14f (diff) | |
| download | linux-35b22c19daa1bbe77dce2f7f776c0cf2acff1f00.tar.bz2 | |
crypto: omap-sham - Drop if with an always false condition
The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so dd is never NULL.
This is a preparation for making platform remove callbacks return void.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
| -rw-r--r-- | drivers/crypto/omap-sham.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c index 4b37dc69a50c..655a7f5a406a 100644 --- a/drivers/crypto/omap-sham.c +++ b/drivers/crypto/omap-sham.c @@ -2197,8 +2197,7 @@ static int omap_sham_remove(struct platform_device *pdev) int i, j; dd = platform_get_drvdata(pdev); - if (!dd) - return -ENODEV; + spin_lock_bh(&sham.lock); list_del(&dd->list); spin_unlock_bh(&sham.lock); |