diff options
| author | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-19 15:00:12 +0200 |
|---|---|---|
| committer | Miquel Raynal <miquel.raynal@bootlin.com> | 2020-05-31 10:53:35 +0200 |
| commit | 2d9cf6f129f8e6730d568628c920fe3b591a34be (patch) | |
| tree | 53cdd32aa1855fd5551f7d8ff8cb741fb9cf5f1a | |
| parent | 0a5f45e57e35d0840bedb816974ce2e63406cd8b (diff) | |
| download | linux-2d9cf6f129f8e6730d568628c920fe3b591a34be.tar.bz2 | |
mtd: rawnand: oxnas: Stop using nand_release()
This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().
Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-40-miquel.raynal@bootlin.com
| -rw-r--r-- | drivers/mtd/nand/raw/oxnas_nand.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/oxnas_nand.c b/drivers/mtd/nand/raw/oxnas_nand.c index 23c222b6c40e..8d0d76ad319d 100644 --- a/drivers/mtd/nand/raw/oxnas_nand.c +++ b/drivers/mtd/nand/raw/oxnas_nand.c @@ -182,7 +182,8 @@ static int oxnas_nand_remove(struct platform_device *pdev) for (i = 0; i < oxnas->nchips; i++) { chip = oxnas->chips[i]; - nand_release(chip); + WARN_ON(mtd_device_unregister(nand_to_mtd(chip))); + nand_cleanup(chip); } clk_disable_unprepare(oxnas->clk); |