summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJie Wang <wangjie125@huawei.com>2022-11-14 16:20:47 +0800
committerPaolo Abeni <pabeni@redhat.com>2022-11-15 13:29:26 +0100
commit29df7c695ed67a8fa32bb7805bad8fe2a76c1f88 (patch)
treec2e05a8cd26e7cdfde5bdbb98d5bd8bf39556cb6
parenta56cad694767ebdb7d80f27ffc239db46fff64de (diff)
downloadlinux-29df7c695ed67a8fa32bb7805bad8fe2a76c1f88.tar.bz2
net: hns3: fix return value check bug of rx copybreak
The refactoring of rx copybreak modifies the original return logic, which will make this feature unavailable. So this patch fixes the return logic of rx copybreak. Fixes: e74a726da2c4 ("net: hns3: refactor hns3_nic_reuse_page()") Fixes: 99f6b5fb5f63 ("net: hns3: use bounce buffer when rx page can not be reused") Signed-off-by: Jie Wang <wangjie125@huawei.com> Signed-off-by: Hao Lan <lanhao@huawei.com> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
-rw-r--r--drivers/net/ethernet/hisilicon/hns3/hns3_enet.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 7fc83409f257..028577943ec5 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -3778,8 +3778,8 @@ static void hns3_nic_reuse_page(struct sk_buff *skb, int i,
desc_cb->reuse_flag = 1;
} else if (frag_size <= ring->rx_copybreak) {
ret = hns3_handle_rx_copybreak(skb, i, ring, pull_len, desc_cb);
- if (ret)
- goto out;
+ if (!ret)
+ return;
}
out: