diff options
| author | Alexander Sverdlin <alexander.sverdlin@nokia.com> | 2022-09-07 14:16:29 +0200 |
|---|---|---|
| committer | Rob Herring <robh@kernel.org> | 2022-09-07 10:54:55 -0500 |
| commit | 27244cbda82787c9283ce79f5e7bea8ecaa58dff (patch) | |
| tree | b1ee6be7eab63e6506d0c17c62ca465f5c079458 | |
| parent | ed18a9b140bc2e3728be9c18b97df07cdd0fe33a (diff) | |
| download | linux-27244cbda82787c9283ce79f5e7bea8ecaa58dff.tar.bz2 | |
of: irq: Report individual failures in of_irq_init()
New pr_err(), a copy of preceeding pr_debug(), faciliates debugging.
This change was inspired by a long lasting debugging of the
octeon_irq_init_ciu() which fails completely silently and leaves the
interrupt controller half-way configured which in turn had very non-obvious
effects.
Signed-off-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Link: https://lore.kernel.org/r/20220907121629.54330-1-alexander.sverdlin@nokia.com
Signed-off-by: Rob Herring <robh@kernel.org>
| -rw-r--r-- | drivers/of/irq.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/of/irq.c b/drivers/of/irq.c index d22f605fa7ee..2bac44f09554 100644 --- a/drivers/of/irq.c +++ b/drivers/of/irq.c @@ -592,6 +592,9 @@ void __init of_irq_init(const struct of_device_id *matches) ret = desc->irq_init_cb(desc->dev, desc->interrupt_parent); if (ret) { + pr_err("%s: Failed to init %pOF (%p), parent %p\n", + __func__, desc->dev, desc->dev, + desc->interrupt_parent); of_node_clear_flag(desc->dev, OF_POPULATED); kfree(desc); continue; |