summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZhang Lixu <lixu.zhang@intel.com>2019-10-16 08:15:59 +0800
committerJiri Kosina <jkosina@suse.cz>2019-10-16 08:26:55 +0200
commit16ff7bf6dbcc6f77d2eec1ac9120edf44213c2f1 (patch)
tree2a11733e02885861dad75c6741a815d124abfc15
parent9e4dbc4646a84b2562ea7c64a542740687ff7daf (diff)
downloadlinux-16ff7bf6dbcc6f77d2eec1ac9120edf44213c2f1.tar.bz2
HID: intel-ish-hid: fix wrong error handling in ishtp_cl_alloc_tx_ring()
When allocating tx ring buffers failed, should free tx buffers, not rx buffers. Signed-off-by: Zhang Lixu <lixu.zhang@intel.com> Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
-rw-r--r--drivers/hid/intel-ish-hid/ishtp/client-buffers.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
index 1b0a0cc605e7..513d7a4a1b8a 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
@@ -84,7 +84,7 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
return 0;
out:
dev_err(&cl->device->dev, "error in allocating Tx pool\n");
- ishtp_cl_free_rx_ring(cl);
+ ishtp_cl_free_tx_ring(cl);
return -ENOMEM;
}