summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChangcheng Deng <deng.changcheng@zte.com.cn>2021-12-14 11:44:47 +0000
committerDavid S. Miller <davem@davemloft.net>2021-12-14 12:49:47 +0000
commit13510fef48a3803d9ee8f044b015dacfb06fe0f5 (patch)
treeb11432d28ecc59893ccc66f2f905a3c35f3fc4e4
parent256f8d72a51e77d1eaab6094a3d6ae4978d1dbd0 (diff)
downloadlinux-13510fef48a3803d9ee8f044b015dacfb06fe0f5.tar.bz2
pktgen: use min() to make code cleaner
Use min() in order to make code cleaner. Issue found by coccinelle. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn> Reviewed-by: Muchun Song <songmuchun@bytedance.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--net/core/pktgen.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/net/core/pktgen.c b/net/core/pktgen.c
index 560a5e712dc3..239effb42b61 100644
--- a/net/core/pktgen.c
+++ b/net/core/pktgen.c
@@ -2778,8 +2778,7 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb,
}
i = 0;
- frag_len = (datalen/frags) < PAGE_SIZE ?
- (datalen/frags) : PAGE_SIZE;
+ frag_len = min(datalen / frags, PAGE_SIZE);
while (datalen > 0) {
if (unlikely(!pkt_dev->page)) {
int node = numa_node_id();
@@ -2796,7 +2795,7 @@ static void pktgen_finalize_skb(struct pktgen_dev *pkt_dev, struct sk_buff *skb,
/*last fragment, fill rest of data*/
if (i == (frags - 1))
skb_frag_size_set(&skb_shinfo(skb)->frags[i],
- (datalen < PAGE_SIZE ? datalen : PAGE_SIZE));
+ min(datalen, PAGE_SIZE));
else
skb_frag_size_set(&skb_shinfo(skb)->frags[i], frag_len);
datalen -= skb_frag_size(&skb_shinfo(skb)->frags[i]);